Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are entering a phase when different client libraries will use different gRPC implementations (most will be migrated to
@grpc/grpc-js
but some will still stay withgrpc
), we'd like to have an easy way for the client library to set the gRPC version in the headers without actually knowing if thegrpc
instance they work with is a C-core or JS implementation.Can we have this
grpc.version
added to both implementations to make this tracking easier? (or feel free to suggest another options!)