Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

availability guard usages of async stream #1705

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Nov 2, 2023

No description provided.

@@ -14,7 +14,8 @@
* limitations under the License.
*/

#if swift(<5.9)
//#if swift(<5.9)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #if needs to stay -- makeStream was added in 5.9, this is a backport.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't mean to commit that, I was using it so I could see the call-sites

@glbrntt glbrntt added the version/v2 Relates to v2 label Nov 2, 2023
@rnro rnro force-pushed the availability_guard_asncstream_usages branch from 252c13d to 676ab6b Compare November 2, 2023 13:08
@rnro rnro force-pushed the availability_guard_asncstream_usages branch from 676ab6b to 9d20673 Compare November 2, 2023 13:08
@rnro rnro requested a review from glbrntt November 2, 2023 13:08
@glbrntt glbrntt merged commit 8a5cb56 into grpc:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/v2 Relates to v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants