Bring over structured Swift syntax from OpenAPI #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We’ll need to be able to represent code to generate as structured Swift types for the new Codegen library. This is effectively what swift-syntax provides but we can’t (at time of writing) take it as a dependency because of its unstable API. Swift OpenAPI Generator has already provided a number of these types as its StructuedSwiftRepresentation. Modifications: - Copied StructuredSwiftRepresentation.swift inside the Codegen library module - Mentioned the usage in NOTICES.txt Result: Codegen library will have a representation of the code to generate as structured Swift types.
glbrntt
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We’ll need to be able to represent the code to be generated as structured Swift types for the new Codegen library. This is effectively what swift-syntax provides but we can’t (at time of writing) take it as a dependency because of its unstable API. Swift OpenAPI Generator has already provided a number of these types as its StructuedSwiftRepresentation.
Modifications:
Result:
Codegen library will have a representation of the code to generate as structured Swift types.