Skip to content

Commit

Permalink
Fix leaked db connections in SpringTransactionManager (#167)
Browse files Browse the repository at this point in the history
  • Loading branch information
amseager authored Aug 11, 2021
1 parent 559ab65 commit b5659de
Showing 1 changed file with 29 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package com.gruelbox.transactionoutbox;

import static com.gruelbox.transactionoutbox.Utils.uncheck;
import static com.gruelbox.transactionoutbox.Utils.uncheckedly;

import java.lang.reflect.InvocationHandler;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
Expand Down Expand Up @@ -29,6 +32,32 @@ public class SpringTransactionManager implements ThreadLocalContextTransactionMa
this.dataSource = dataSource;
}

@Override
@Transactional(propagation = Propagation.REQUIRES_NEW)
public void inTransaction(Runnable runnable) {
uncheck(() -> inTransactionReturnsThrows(ThrowingTransactionalSupplier.fromRunnable(runnable)));
}

@Override
@Transactional(propagation = Propagation.REQUIRES_NEW)
public void inTransaction(TransactionalWork work) {
uncheck(() -> inTransactionReturnsThrows(ThrowingTransactionalSupplier.fromWork(work)));
}

@Override
@Transactional(propagation = Propagation.REQUIRES_NEW)
public <T> T inTransactionReturns(TransactionalSupplier<T> supplier) {
return uncheckedly(
() -> inTransactionReturnsThrows(ThrowingTransactionalSupplier.fromSupplier(supplier)));
}

@Override
@Transactional(propagation = Propagation.REQUIRES_NEW)
public <E extends Exception> void inTransactionThrows(ThrowingTransactionalWork<E> work)
throws E {
inTransactionReturnsThrows(ThrowingTransactionalSupplier.fromWork(work));
}

@Override
@Transactional(propagation = Propagation.REQUIRES_NEW)
public <T, E extends Exception> T inTransactionReturnsThrows(
Expand Down

0 comments on commit b5659de

Please sign in to comment.