Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure retry policy on a per-task basis #790

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nishiol
Copy link

@nishiol nishiol commented Jan 29, 2025

Based on discussion: #737

Similar PR: #739

Allows to configure retry policy on per-task basis in programmatic way. No db migrations needed.
Usage example can be found in README.md

@lburja could you please also take a look at this PR?

@lburja
Copy link

lburja commented Jan 31, 2025

The ideea looks interesting. The upside is that DB changes are not needed, and there is flexibility in applying different strategies. The downside is that you need to implement a specific interface.

I didn’t review in detail at the code, but from what I can tell, the idea should work

@nishiol
Copy link
Author

nishiol commented Jan 31, 2025

Yes, it's kind of tight coupling. But if this a problem, it could be avoided by creating an implementing class in the module which depends on transaction-outbox stuff. It'll look like some wrapper around your business logic class which you want to be called by transaction-outbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants