Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add token lib #155

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add token lib #155

merged 1 commit into from
Oct 29, 2020

Conversation

nagayev
Copy link

@nagayev nagayev commented Oct 29, 2020

Imported from Cpython.

@nagayev
Copy link
Author

nagayev commented Oct 29, 2020 •
edited
Loading

@rezaghanbari
The build was unsuccessful, but maybe it's not my fault (there is no error in my file).

@alanjds
Copy link

alanjds commented Oct 29, 2020

yeah... from the CI log on https://travis-ci.org/github/grumpyhome/grumpy/jobs/739947996#L887-L899 looks like isort is trying to install some the Python 3.5+ code.

And Grumpy unfortunately still runs on Python 2.7 🤷

@nagayev
Copy link
Author

nagayev commented Oct 29, 2020 •
edited
Loading

@alanjds So what do you want to do?
You can merge my PR and then try to fix the issue about Python 3.5.

@alanjds
Copy link

alanjds commented Oct 29, 2020

Yeah... I do not think that merging your PR can make anything break. Yet do not know where it helps.

Will merge it and hope for someone to have time to push forward the Python 2.7 -> 3.X migration described on #135

@alanjds alanjds merged commit a3573e1 into grumpyhome:master Oct 29, 2020
@alanjds alanjds mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagayev @alanjds