Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write new files only if file size is reduced #400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattyrob
Copy link

This PR slightly updated the logic when processing files through the minification process.

Currently a conditional statement tracks if the file size has been reduced but all of the files a re-written, this means that files of the same size, or even larger files could be produced.

Moving the file write commands within the conditional statement will ensure files are only written when the file size has been reduced.

Also, I have included updated package-lock.json that includes some minor dependency updates that should be no-breaking without further manual testing required.

@mattyrob
Copy link
Author

The Dependency upgrade address (all) 6 Critical, 12 High and 7 Moderate rated vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant