Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved resolveJasmine/jasminePromise function to fix scope issue #300

Merged
merged 1 commit into from
May 4, 2020

Conversation

TristanNovo
Copy link
Contributor

This PR relates to issue 299

Upon further inspection I noticed that the function that is awaited until the jasmine tests complete is defined closer to the top of the file where I don't believe it is getting properly reset between multi tasks, causing the strange behavior I observed.

I've simply moved that function definition into the launchPuppeteer function and explicitly pass it into the setup function, and this seems to fix the issue.

@jsf-clabot
Copy link

jsf-clabot commented Mar 5, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@steveoh
Copy link
Contributor

steveoh commented Mar 11, 2019

looks fine to me. Just need a CLA signature and I think we are ok.

@steveoh
Copy link
Contributor

steveoh commented Jun 6, 2019

@TristanNovo will you rebase with master to fix conflicts and sign the cla to get this merged?

@matthew-dean
Copy link

@TristanNovo Any update to this?

@steveoh
Copy link
Contributor

steveoh commented Aug 5, 2019

Someone with a signed cla will probably need to duplicate this behavior. @TristanNovo is not responding. @matthew-dean do you want to take care of it?

ChrisBoet added a commit to ChrisBoet/grunt-contrib-jasmine that referenced this pull request Oct 11, 2019
@vladikoff vladikoff merged commit 444aa37 into gruntjs:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cla CLA is required for all code commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants