Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - issues/3066 - add include description #3070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pritho
Copy link

@pritho pritho commented Apr 18, 2024

Description

Fixes #3306.

Include additional help for reusing globally defined variables

Release Notes (draft)

Added extended documentation for reusing globally defined variables

Summary by CodeRabbit

  • Documentation
    • Enhanced guidance on using locals in configuration, clarifying their limitations across different files.
    • Introduced a new example detailing an alternative method for global variable reuse using external YAML or JSON files.
    • Improved text structure and clarity with reorganized content and updated headings.

@pritho pritho requested a review from denis256 as a code owner April 18, 2024 08:18
@denis256
Copy link
Member

Hm, not sure if the changes explain how to use merge_strategy = "deep"
I think it will be helpful to show end to end examples of how to use include and merge_strategy

@yhakbar
Copy link
Collaborator

yhakbar commented Aug 5, 2024

Hey @pritho , do you mind rebasing, then following up on @denis256 's comment?

@yhakbar yhakbar changed the title issues/3066 - add include description WIP - issues/3066 - add include description Aug 13, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for submitting this pull request.

@github-actions github-actions bot added the stale Stale label Feb 15, 2025
Copy link
Contributor

coderabbitai bot commented Feb 15, 2025

Walkthrough

The changes update the Terragrunt documentation for the locals feature. The documentation now clarifies that locals defined in a parent configuration of an include block are not automatically available in the child configuration. Additionally, a new section demonstrates how to reuse variables globally using YAML or JSON files, complete with an example for defining a common_vars.yaml file and including it in a child configuration. The text was also reorganized for improved clarity.

Changes

File Change Summary
docs/_docs/02_features/locals.md - Clarified that locals in parent configs are not inherited automatically in child configs
- Added a section with an example for global variable reuse via YAML/JSON
- Minor reorganization for clarity

Sequence Diagram(s)

sequenceDiagram
    participant C as Child Terragrunt Config
    participant FS as File System
    participant YD as YAML Decoder

    C->>FS: Load 'common_vars.yaml' using file()
    FS-->>C: Return YAML content
    C->>YD: Decode content with yamldecode()
    YD-->>C: Return global variables
    C-->>C: Utilize variables in locals block
Loading

Suggested reviewers

  • denis256

Poem

In docs and code, a tale unfolds,
Guiding locals with ideas bold.
YAML whispers secrets clear and neat,
Merging variables in a rhythmic beat.
A change so bright, a joyful art—
Our docs now sing, a brand new start!
🚀📚


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/_docs/02_features/locals.md (1)

45-50: Clarify and Enhance the Global Locals Section

The new section on reusing variables globally is a strong addition, and it helps clear up the current limitations very nicely. A couple of suggestions for further improvement:

  • Wording Precision: On line 45, instead of “available to terragrunt,” consider wording it as “accessible within Terragrunt” or “utilized by Terragrunt” to improve clarity.
  • Context for Alternatives: The mention of the merge_strategy = "deep" option on line 47 is a valuable alternative. A brief note on when you might choose this strategy over the YAML/JSON approach would guide users better.
  • Semantic Headings: In line 49, the example header is marked up in bold. For better semantic structure and consistency with the rest of the documentation, consider converting this into a heading (for example, using #### Example for using "yaml" or "json" files:).
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14b45a9 and d591bb9.

📒 Files selected for processing (1)
  • docs/_docs/02_features/locals.md (1 hunks)

@github-actions github-actions bot removed the stale Stale label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants