-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - issues/3066 - add include description #3070
base: main
Are you sure you want to change the base?
Conversation
Hm, not sure if the changes explain how to use |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for submitting this pull request. |
WalkthroughThe changes update the Terragrunt documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Child Terragrunt Config
participant FS as File System
participant YD as YAML Decoder
C->>FS: Load 'common_vars.yaml' using file()
FS-->>C: Return YAML content
C->>YD: Decode content with yamldecode()
YD-->>C: Return global variables
C-->>C: Utilize variables in locals block
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/_docs/02_features/locals.md (1)
45-50
: Clarify and Enhance the Global Locals SectionThe new section on reusing variables globally is a strong addition, and it helps clear up the current limitations very nicely. A couple of suggestions for further improvement:
- Wording Precision: On line 45, instead of “available to
terragrunt
,” consider wording it as “accessible within Terragrunt” or “utilized by Terragrunt” to improve clarity.- Context for Alternatives: The mention of the
merge_strategy = "deep"
option on line 47 is a valuable alternative. A brief note on when you might choose this strategy over the YAML/JSON approach would guide users better.- Semantic Headings: In line 49, the example header is marked up in bold. For better semantic structure and consistency with the rest of the documentation, consider converting this into a heading (for example, using
#### Example for using "yaml" or "json" files:
).
Description
Fixes #3306.
Include additional help for reusing globally defined variables
Release Notes (draft)
Added extended documentation for reusing globally defined variables
Summary by CodeRabbit