feat: add translation error handling #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough📝 WalkthroughWalkthrough이 변경 사항은 Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
lib/app/modules/notices/presentation/pages/notice_edit_body_page.dart (1)
284-307: 오류 처리 구현이 개선되었습니다.번역 기능의 오류 처리가 체계적으로 구현되었습니다. 다만 몇 가지 개선 사항을 제안드립니다:
- 일반적인 예외 메시지는 사용자가 이해하기 어려울 수 있습니다. 사용자 친화적인 오류 메시지를 표시하는 것이 좋겠습니다.
- 오류가 발생했을 때 분석 이벤트를 추가하면 문제 추적에 도움이 될 것 같습니다.
다음과 같이 개선하는 것을 제안드립니다:
try { final bloc = context.read<AiBloc>(); final blocker = bloc.stream.firstWhere((s) => s.hasResult); bloc.add(AiEvent.request( body: _koreanBodyController.html, lang: Language.en, )); final result = await blocker; if (!mounted) return; result.mapOrNull( loaded: (result) { AnalyticsRepository.action( const AnalyticsEvent.noticeEditBodyUseAiTranslation()); return _englishBodyController.html = result.body; }, error: (error) { context.showToast(error.message); + AnalyticsRepository.error( + const AnalyticsEvent.noticeEditBodyTranslationError()); }, ); } catch (e) { if (mounted) { - context.showToast(e.toString()); + context.showToast(context.t.notice.translation.error); + AnalyticsRepository.error( + const AnalyticsEvent.noticeEditBodyTranslationError()); } }lib/app/modules/notices/presentation/pages/notice_write_body_page.dart (1)
332-350: 기본적인 오류 처리가 잘 구현되었습니다.오류 처리 로직이 추가되어 사용자 경험이 개선되었습니다. 다만 다음과 같은 개선사항을 제안드립니다:
- 구체적인 예외 타입에 따른 처리
- 디버깅을 위한 로깅 추가
- 재시도 메커니즘 구현 검토
다음과 같이 개선해 보시는 것은 어떨까요:
Future<void> _translate() async { try { final bloc = context.read<AiBloc>(); final blocker = bloc.stream.firstWhere((s) => s.hasResult); bloc.add(AiEvent.request( body: _koreanBodyController.html, lang: Language.en, )); final result = await blocker; result.mapOrNull( loaded: (result) => _englishBodyController.html = result.body, error: (error) { + debugPrint('Translation error: ${error.message}'); context.showToast(error.message); }, ); } catch (e) { + debugPrint('Unexpected error during translation: $e'); if (mounted) { - context.showToast(e.toString()); + context.showToast(context.t.common.unexpectedError); } } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
lib/app/modules/notices/presentation/pages/notice_edit_body_page.dart(1 hunks)lib/app/modules/notices/presentation/pages/notice_write_body_page.dart(1 hunks)
2paperstar
requested changes
Nov 16, 2024
2paperstar
previously approved these changes
Nov 16, 2024
lib/app/modules/notices/presentation/pages/notice_edit_body_page.dart
Outdated
Show resolved
Hide resolved
|
이 PR에 4.1.4 로 버전 업그레이드 하는거 넣어주시구 머지 후에 배포해주세요! |
GwanLiZa
dismissed stale reviews from 2paperstar and coderabbitai[bot]
via
1efaf88
2paperstar
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
4.1.3에서4.1.4로 변경되었습니다.