Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #12 correct handling of format argument #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

craigedmunds
Copy link

I don't think the defaulting of format to json is necessary at all? Although the absence of tests makes it difficult to gauge!

@farmerpaul
Copy link

farmerpaul commented Mar 17, 2021

I agree, not sure what the rationale is behind those original lines of code (if the format parameter already exists, then change it to json, but then if it doesn't exist, don't do anything?). I had to use your fork in my project to make any progress in using the search_replace command, thanks for posting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants