Regenerate with properties/async attributes support #1425
Conversation
|
This is still waiting on the gir file update, right? |
|
Yes, should trigger an update of the gir files and see if that landed already |
|
This can be regenerated now |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/regen-2
branch
from
08a64c7 to
0d16003
Compare
| } | ||
| //#[cfg(feature = "v2_82")] | ||
| //#[cfg_attr(docsrs, doc(cfg(feature = "v2_82")))] | ||
| //#[doc(alias = "g_file_copy_async_with_closures")] |
There was a problem hiding this comment.
The fix for this still hasn't landed on the gir file? cc @A6GibKm
There was a problem hiding this comment.
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4099 I think it is only in main, I don't think I have updated this gir file on gir-files.
There was a problem hiding this comment.
Latest update to the gir at gir-files was 2 weeks ago, patch was merged a week ago, so no, it is not in there.
There was a problem hiding this comment.
I see it here <method name="copy_async_with_closures" c:identifier="g_file_copy_async_with_closures" shadows="copy_async" version="2.82" glib:finish-func="copy_finish">
There was a problem hiding this comment.
From a quick look, it seems like the finish-func annotation is wrongly set in that function. It probably needs a manual implementation to turn it into a future instead of still using closures.
There was a problem hiding this comment.
There was a problem hiding this comment.
@bilelmoussaoui can you ping ebassi about that? Would be good to get this in to not have this PR bitrot
|
This here also updates |
No description provided.