Additional gtk4 update #347

KonstantIMP · 2022-01-16T15:20:04Z

With this commit I have made some changes which should improve GtkD usage experience.

First of all I want to say that compiletime link of gtk and other G-type libraries is useless. On unix based machines we always have dynamic libraries(or can download it via our packet manager) and so don't need static linkage in general. If we talk about Windows computers - it is a bit more easier to download .dll files from MSYS or like this than compile it yourself. GTK applications becomes more popular, it means that using of dynamic libraries is better because this way uses less memory: (some shared libraries)*1 < (some apps with staticly linked libraries)*n. I made some changes because think that it is truth.

The libraries are separated now. You can connect only one of them and forget about other. For example, you can import just GLib without GUI support(gtk widgets, gsk renderer and etc.).
Linker class is in linker package now. It is not a part of Gtk, Glib or like this, so it should have different module path. Now it is gtk-d:linker
Update examples. Gtk api was changed from 3 version. Some examples was fixed
Work with libraries: add gtk4 wrap for gtksourceview5, connect libsoup, libshumate and libadwaita(thank @WebFreak001), temporary remove gstreamer - it has not been ported to gtk4 yet
Also update scripts for docs generation
Remove all build methods except dub. build everything you want with: dub build gtk-d:[module name]

Additional info: because gtkd.Loader was replaced by linker.Loader there are some changes in gir-to-d. I forked it and replaced wrap/ link with my repo

* Remove useless gtkd.Paths * Replace gtkd.Linker with linker.Linker because this class is not part of gtk and should have own package * Add LinkException - only for link errors

* All libraries are separeted now. It means that you shouldn't have all libraries installed on your computer. If you need just gtk you don't need to install sourceview, libsoup and other It should decrease number of dll files for windows projects

not supported by official version * gtkd.Linker was replaced with linker.Linker * Was removed useless isLoaded(string []). It always calls isLoaded(string) just with the first element. So it was fixed in gir-to-d

Everything can be compiled by dub

So makefile was removed

WebFreak001

maybe it would be better to leave broken examples existing? Quite a lot of interesting stuff has been removed, that might come back later
accidentally committed binary file demos/shumate/simpleMap/Map

WebFreak001 · 2022-01-17T10:16:37Z

demos/cairo/cairo_clock/clock.d

-		addOnDraw(&drawCallback);
+		setDrawFunc ((area, cairo, w, h, data) {
+            (cast(Clock)data).drawCallback (new Context (cairo));
+        }, cast(void *)this, null);


missing D wrapper of setDrawFunc to transfer context scope? (could access this in callback immediately then and not do the unsafe void* casts to this)

Should also probably not call GC (new Context) inside a draw function and rather use something like scope c = new Context(cairo); and scope Context cr as parameter to use stack allocated Context class?

I think that it is possible to write more comfortable wrapper for setDrawFunc(), but there is a small question.
Is it better to create a something like public draw(Scoped!Canvas) method for the DrawingArea class and allow to override it or use addOnDraw(delegate (Scoped!Context))?
And I agree that using Scoped~Context is better. Will be replaced

WebFreak001 · 2022-01-17T10:18:30Z

demos/cairo/text_image/text_image.d

-		addOnDraw(&drawCallback);
+		setDrawFunc ((area, cairo, w, h, data) {
+            (cast(CairoText)data).drawCallback (new Context (cairo));
+        }, cast(void *)this, null);


WebFreak001 · 2022-01-17T10:19:35Z

demos/pango/pangocairo.d

-		addOnDraw(&drawText);
+		setDrawFunc ((area, cairo, w, h, data) {
+            (cast(PangoText)data).drawText (new Context (cairo));
+        }, cast(void *)this, null);


WebFreak001 · 2022-01-17T10:23:55Z

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "wrap"]
 	path = wrap
-	url = https://github.com/gtkd-developers/gir-to-d.git
+	url = https://github.com/KonstantIMP/gir-to-d


make PR to gir-to-d?

WebFreak001 · 2022-01-17T10:26:48Z

demos/gtkD/DemoActions/DemoActions.d

@@ -67,18 +67,18 @@ class MainWindow : ApplicationWindow {

        //HeaderBar
        HeaderBar hb = new HeaderBar();
-        hb.setShowCloseButton(true);
-        hb.setTitle("Actions Demo, Click the menu button >>>");
+        //hb.setShowCloseButton(true);


remove, don't comment

WebFreak001 · 2022-01-17T10:41:46Z

source/APILookupShumate.txt

+	 */
+	public this(bool defaults = false)
+	{
+		ShumateMapSourceRegistry* __p;


ditto for double underscore

WebFreak001 · 2022-01-17T10:41:52Z

source/APILookupShumate.txt

+	 */
+	public this(bool simple = false)
+	{
+		auto __p = (simple ? shumate_map_new_simple() : shumate_map_new());


ditto for double underscore

WebFreak001 · 2022-01-17T10:43:47Z

source/APILookupSoup.txt

+    public SoupSocketIOStatus readUntil(ubyte[] buffer, void* boundary, size_t boundaryLen, out size_t nread, bool* gotBoundary, Cancellable cancellable) {
+        GError* err = null;
+
+        auto __p = soup_socket_read_until(soupSocket, buffer.ptr, cast(size_t)buffer.length, boundary, boundaryLen, &nread, cast(int *)gotBoundary, (cancellable is null) ? null : cancellable.getCancellableStruct(), &err);


ditto for double underscore

WebFreak001 · 2022-01-17T10:44:07Z

source/APILookupSoup.txt

+    }
+
+    return __p;


missing indent?

WebFreak001 · 2022-01-17T10:55:38Z

source/APILookupSoup.txt

+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110, USA
+#
+wrap: soup
+file: Soup-2.4.gir


should we use soup 3 or later with gtk 4? (e.g. replaced SoupBuffer with Gio Bytes)

For shumate that requires -Dlibsoup3=true though

I had to use soup 3 for the latest shumate version.

MikeWey

First of all I want to say that compiletime link of gtk and other G-type libraries is useless.

What the Makefile / gir-to-d calls compiletime isn't static linking, but it will link with the dynamic libraries using the linker instead of calling ld for every function on program start up. This has a small performance benefit, and it allows ldd to actually see what libraries your application uses. That can be beneficial for creating Debian packages for example which uses ldd to figure out what dependencies are needed when creating the package.

MikeWey · 2022-01-17T11:26:12Z

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "wrap"]
 	path = wrap
-	url = https://github.com/gtkd-developers/gir-to-d.git
+	url = https://github.com/KonstantIMP/gir-to-d


MikeWey · 2022-01-17T11:29:04Z

GNUmakefile

@@ -1,314 +0,0 @@
-SHELL=/bin/sh


Maybe i'm weird, but i'm one of those people that doesn't usually use dub.

I also think distro packagers mostly prefer using the make file to build GtkD.

Hm. Sounds logically. So Makefile should be. I will try to rewrite it for the changes or return existing with some fixes.

MikeWey · 2022-01-17T11:31:31Z

dub.json

-            "dependencies": {"gtk-d:gtkd":"*"}
-        }
-    ]
+    "subPackages": [


With how this is now structured, wouldn't it be better to separate things out into different repositories?

Like whats already been done for GLib: https://github.com/gtkd-developers/GlibD

for the core packages instead of different repositories I would recommend using subpackages in separate folders (useful to install all the common stuff at once)

With how this is now structured, wouldn't it be better to separate things out into different repositories?

Like whats already been done for GLib: https://github.com/gtkd-developers/GlibD

It will be harder to update packages I think.

MikeWey · 2022-01-17T11:35:09Z

demos/cairo/cairo_clock/clock.d

 	}

 protected:
 	//Override default signal handler:
-	bool drawCallback(Scoped!Context cr, Widget widget)
+	bool drawCallback(Context cr)


Without Scoped you will either need to free things manually every drawCallback, or you will have a large memory leak, this because the D GC doesn't see the large Context associated with the D object and so it will take a long time for the contexts to be collected.

jjardon · 2022-03-06T00:42:35Z

demos/gl/core/CoreGL.d

@@ -44,8 +44,8 @@ int main(string[] args)
    mainWnd.setTitle("Simplest GLArea + CoreGL Example");

    auto wnd = new CoreGL;
-    mainWnd.add(wnd);
-    mainWnd.showAll();
+    mainWnd.setChild(wnd);


@KonstantIMP , Trying to compile this with:

$ gdc CoreGL.d pkg-config gtkd-3 gl --cflags --libs

I'm getting:

CoreGL.d:47:12: error: no property ‘setChild’ for type ‘gtk.ApplicationWindow.ApplicationWindow’, did you mean ‘gtk.Bin.Bin.getChild’? 47 | mainWnd.setChild(wnd); | ^

Ah nevermind, this is of course beacuse gtkd in my system is against gtk3 still

dejlek · 2023-02-02T10:39:24Z

@KonstantIMP this is just too large PR to review...

KonstantIMP added 13 commits January 16, 2022 12:06

Worh with livraries linker

e85cb70

* Remove useless gtkd.Paths * Replace gtkd.Linker with linker.Linker because this class is not part of gtk and should have own package * Add LinkException - only for link errors

Update Lookups for wrapper generation

03f334c

Replace src/ to source/ and fix wrap errors

ab7d1a6

Improve dependencies connection

77c8fbe

* All libraries are separeted now. It means that you shouldn't have all libraries installed on your computer. If you need just gtk you don't need to install sourceview, libsoup and other It should decrease number of dll files for windows projects

Temporary it pointer to my repository, because I made some changes which

c30e7d1

not supported by official version * gtkd.Linker was replaced with linker.Linker * Was removed useless isLoaded(string []). It always calls isLoaded(string) just with the first element. So it was fixed in gir-to-d

Update lookups and regen the wrapper

139f0a7

I added me

833174e

Build.d script is useless

9785173

Everything can be compiled by dub

DUB can build everything now

68491a6

So makefile was removed

Update Lookups and fix errors

2569a4f

Update docs generation

2c9122e

Fix some build errors

5013831

Update examples

0e9007a

WebFreak001 reviewed Jan 17, 2022

View reviewed changes

MikeWey requested changes Jan 17, 2022

View reviewed changes

Remove binaries

9441b1e

KonstantIMP mentioned this pull request Jan 29, 2022

Changes for new gtk4 wrap gtkd-developers/gir-to-d#41

Open

Remove useless lines

38c015d

jjardon reviewed Mar 6, 2022

View reviewed changes

Update bindings

9456ae7

MikeWey mentioned this pull request Sep 1, 2022

GTK4 #350

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional gtk4 update #347

Additional gtk4 update #347

KonstantIMP commented Jan 16, 2022

WebFreak001 left a comment

WebFreak001 Jan 17, 2022

KonstantIMP Jan 29, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

MikeWey Jan 17, 2022

KonstantIMP Jan 29, 2022

WebFreak001 Jan 17, 2022

KonstantIMP Jan 29, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

WebFreak001 Jan 17, 2022

EsoCoding Mar 17, 2023

MikeWey left a comment

MikeWey Jan 17, 2022

MikeWey Jan 17, 2022

KonstantIMP Jan 29, 2022

MikeWey Jan 17, 2022

WebFreak001 Jan 17, 2022

KonstantIMP Jan 29, 2022

MikeWey Jan 17, 2022

jjardon Mar 6, 2022

jjardon Mar 6, 2022

dejlek commented Feb 2, 2023

Additional gtk4 update #347

Are you sure you want to change the base?

Additional gtk4 update #347

Conversation

KonstantIMP commented Jan 16, 2022

WebFreak001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeWey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dejlek commented Feb 2, 2023