Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State data recording fixes #23

Merged
merged 1 commit into from
Jan 3, 2025
Merged

State data recording fixes #23

merged 1 commit into from
Jan 3, 2025

Conversation

JamesArruda
Copy link
Collaborator

  1. Opted to make the state's instantiation non-lazy - the Actor has the state set the default right away
  2. Default setting of the state goes right to recording as well
  3. Fixed the continue vs break bug
  4. Fixed a DetectabilityState bug revealed by changes. The motion manager call happened when the initial state setting went to the recording method, but that's a case where the motion manager doesn't need to know.

@JamesArruda JamesArruda self-assigned this Jan 3, 2025
@JamesArruda JamesArruda linked an issue Jan 3, 2025 that may be closed by this pull request
@JamesArruda JamesArruda marked this pull request as ready for review January 3, 2025 03:57
@JamesArruda JamesArruda merged commit 7aa5a24 into dev Jan 3, 2025
9 checks passed
@JamesArruda JamesArruda deleted the 19-data-gathering-bugs branch January 3, 2025 03:59
JamesArruda added a commit that referenced this pull request Jan 3, 2025
* Docs for data gathering. Updates for usability an clarity.

* Updating NamedEntity and Monitoring resources to assist data gathering.

* New docs for new features. Updated other docs for new features.

* Making states initialize to default right away to correct data gathering bugs. (#23)

* Location data object improvements. (#24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data gathering bugs
1 participant