Slideshow: allow carousel interaction in cards #12852
Open
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3.58 kB (+0.38%) Total Size: 944 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
jamesmockett
force-pushed
the
jm/slideshow-overlay-interaction
branch
from
c3f9063
to
dd53151
Compare
cemms1
reviewed
Nov 18, 2024
| <div className="image-overlay" /> | ||
| )} | ||
| {(imageType === 'picture' || imageType === 'slideshow') && | ||
| !hideImageOverlay && <div className="image-overlay" />} |
There was a problem hiding this comment.
What do we expect to happen when hovering over a card with a slideshow? Do we not still expect the image to dim?
There was a problem hiding this comment.
If it's an existing auto-playing slideshow the image will still dim when hovered, but not if it's a slideshow carousel. As you have to hover over the card to interact with the slideshow it would effectively mean the slideshow images are permanently dimmed as you scroll though them. I'll clarify what the desired effect is here though.
jamesmockett
force-pushed
the
jm/slideshow-overlay-interaction
branch
from
dd53151
to
5ffe8e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
This allows slideshows to be interacted with when added to a front.
Part of the work to support slideshow carousels in DCR, bringing parity between web and app.
Images