Move Types And Functions Out Of article.ts
#12861
Open
+34
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep this file focused on the `Article` type. Moved the `TableOfContentsItem` type to live alongside the functions that create it. Deleted the `TableOfContents` type because it's unused. Created a `pinnedPost.ts` file to manage enhancing pinned posts alongside the other enhancer files. Updated the type of the `block`/`pinnedPost` field; it's not optional given it's the focus of the function, but rather the value might be `undefined`. Also made some small changes to the implementation for clarity.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +3 B (0%) Total Size: 940 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep this file focused on the
Articletype.Moved the
TableOfContentsItemtype to live alongside the functions that create it. Deleted theTableOfContentstype because it's unused.Created a
pinnedPost.tsfile to manage enhancing pinned posts alongside the other enhancer files. Updated the type of theblock/pinnedPostfield; it's not optional given it's the focus of the function, but rather the value might beundefined. Also made some small changes to the implementation for clarity.