Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Primary and Secondary container levels with just SecondaryLevel #334

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Nov 15, 2024

What does this change?

Replaces Primary and Secondary possible metadata values with just SecondaryLevel.

The previous implementation had both Primary and Secondary as metadata options but since all containers are considered "primary" unless specified as "secondary", we can reduce this to just one option. This also includes the word "level" as part of the metadata to better communicate what this does and how it is distinct from a palette option.

How to test

Deploy a pre-release version of this branch (e.g. https://github.com/guardian/facia-scala-client/actions/runs/11892277827) and use this in the facia-tool repo (see commits on guardian/facia-tool#1728). Run the facia-tool locally or deploy to CODE to test changes there.

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@gu-scala-library-release
Copy link
Contributor

@cemms1 has published a preview version of this PR with release workflow run #47, based on commit 363e637:

13.0.0-PREVIEW.cemms1adapt-container-level-naming.2024-11-18T1149.363e637e

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the cemms1/adapt-container-level-naming branch, or use the GitHub CLI command:

gh workflow run release.yml --ref cemms1/adapt-container-level-naming

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@cemms1 has published a preview version of this PR with release workflow run #48, based on commit 909815c:

13.0.0-PREVIEW.cemms1adapt-container-level-naming.2024-11-18T1218.909815c4

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the cemms1/adapt-container-level-naming branch, or use the GitHub CLI command:

gh workflow run release.yml --ref cemms1/adapt-container-level-naming

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@cemms1 cemms1 marked this pull request as ready for review November 18, 2024 16:24
@cemms1 cemms1 marked this pull request as draft November 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant