Replace Primary
and Secondary
container levels with just SecondaryLevel
#334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Replaces
Primary
andSecondary
possible metadata values with justSecondaryLevel
.The previous implementation had both
Primary
andSecondary
as metadata options but since all containers are considered "primary" unless specified as "secondary", we can reduce this to just one option. This also includes the word "level" as part of the metadata to better communicate what this does and how it is distinct from a palette option.How to test
Deploy a pre-release version of this branch (e.g. https://github.com/guardian/facia-scala-client/actions/runs/11892277827) and use this in the
facia-tool
repo (see commits on guardian/facia-tool#1728). Run thefacia-tool
locally or deploy to CODE to test changes there.Deployment