Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 60px margin bottom from form to caption input #1722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Nov 7, 2024

What's changed?

The standard article form has a 60px margin set to it (following this PR), but in hindsight we'd prefer to only display it if the slideshow is in place. The caption input, at the bottom of the slideshow, now has the property, as it only appears when there's a slideshow.

The article form can still have a margin bottom; this has been left in for feast related things.

Screenshots

Before - always 60px margin bottom:

mbbb.mov

After - 60px margin bottom only when showing the caption input:

mbaft.mov

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Georges-GNM Georges-GNM requested a review from a team as a code owner November 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant