Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio data to main media for audio articles #27501

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Sep 26, 2024

What is the value of this and can you measure success?

This will allow us to add an audio player to dcr for audio articles. By passing the audio main media element through FE to dcr

What does this change?

This adds the Audio files to the main media element for audio articles. It passes the audio files and the associated fields if there is no html field or if the other functions are not returning in the get or else.

Screenshots

Before After
before after

Checklist

  • Tested locally, and on CODE if necessary
  • Will not break dotcom-rendering

@oliverabrahams oliverabrahams changed the title Oa/audio pages main media audio Add Audio data to main media for audio articles Sep 26, 2024
@oliverabrahams oliverabrahams changed the title Add Audio data to main media for audio articles Add audio data to main media for audio articles Sep 26, 2024
@oliverabrahams oliverabrahams marked this pull request as ready for review September 26, 2024 13:31
@oliverabrahams oliverabrahams requested a review from a team as a code owner September 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant