Remove Prebid Bidder Performance in Admin Frontend tools

admin/app/controllers/AdminControllers.scala

@@ -101,5 +101,4 @@ trait AdminControllers {
   lazy val tablesController = wire[TablesController]
   lazy val frontsController = wire[FrontsController]
   lazy val adsDotTextController = wire[AdsDotTextEditController]
-  lazy val commercialKPIController = wire[TeamKPIController]
 }

admin/app/views/commercial/commercialMenu.scala.html

@@ -15,7 +15,6 @@ <h3>Performance</h3>
                 <div class="panel-heading">Performance metrics.</div>
                 <div class="panel-body">
                     <ul>
-                        <li><a href="@controllers.admin.commercial.routes.TeamKPIController.renderPrebidDashboard()">Prebid Bidder Performance</a></li>
                         <li><a href="https://eu-west-1.console.aws.amazon.com/cloudwatch/home?region=eu-west-1#dashboards:name=Commercial">AWS performance</a></li>
                         <li><a href="https://console.aws.amazon.com/cost-reports/home?region=eu-west-1#/custom?chartStyle%3DGroup%26timeRangeOption%3DLast14days%26granularity%3DDaily%26reportName%3DCommercial%26filter%3D%5B%7B%22dimension%22:%22Service%22,%22values%22:%5B%22Amazon%20Kinesis%20Firehose%22%5D,%22include%22:true,%22children%22:null%7D%5D%26reportType%3DCostUsage%26hasAmortized%3Dfalse&reportType=CostUsage&granularity=Daily&chartStyle=Group&groupBy=None&forecastTimeRangeOption=None&hasBlended=false&hasAmortized=false&excludeRefund=false&excludeCredit=false&excludeRIUpfrontFees=false&excludeRIRecurringCharges=false&excludeOtherSubscriptionCosts=false&excludeTax=false&excludeSupportCharges=false&excludeTaggedResources=false&reportName=Commercial&timeRangeOption=Last14days&filter=%5B%7B%22dimension%22:%22Service%22,%22values%22:%5B%22Amazon%20Kinesis%20Firehose%22%5D,%22include%22:true,%22children%22:null%7D%5D&isTemplate=false">AWS costs</a></li>
                         <li><a href="https://logs.gutools.co.uk/app/kibana#/discover/e3702cb0-deb0-11e8-8fab-bb8ec5c47fa1?_g%3D(refreshInterval%3A(display%3AOff%2Cpause%3A!f%2Cvalue%3A0)%2Ctime%3A(from%3Anow-15m%2Cmode%3Aquick%2Cto%3Anow))%26_a%3D(columns%3A!(_source)%2Cfilters%3A!((%27%24state%27%3A(store%3AappState)%2Cmeta%3A(alias%3A!n%2Cdisabled%3A!f%2Cindex%3Aafa91900-5e8b-11e8-ba01-2b66550a44f2%2Ckey%3Astack%2Cnegate%3A!f%2Cparams%3A(query%3Afrontend%2Ctype%3Aphrase)%2Ctype%3Aphrase%2Cvalue%3Afrontend)%2Cquery%3A(match%3A(stack%3A(query%3Afrontend%2Ctype%3Aphrase))))%2C(%27%24state%27%3A(store%3AappState)%2Cmeta%3A(alias%3A!n%2Cdisabled%3A!f%2Cindex%3Aafa91900-5e8b-11e8-ba01-2b66550a44f2%2Ckey%3Astage%2Cnegate%3A!f%2Cparams%3A(query%3APROD%2Ctype%3Aphrase)%2Ctype%3Aphrase%2Cvalue%3APROD)%2Cquery%3A(match%3A(stage%3A(query%3APROD%2Ctype%3Aphrase))))%2C(%27%24state%27%3A(store%3AappState)%2Cmeta%3A(alias%3A!n%2Cdisabled%3A!f%2Cindex%3Aafa91900-5e8b-11e8-ba01-2b66550a44f2%2Ckey%3Aapp%2Cnegate%3A!f%2Cparams%3A(query%3Acommercial%2Ctype%3Aphrase)%2Ctype%3Aphrase%2Cvalue%3Acommercial)%2Cquery%3A(match%3A(app%3A(query%3Acommercial%2Ctype%3Aphrase)))))%2Cindex%3Aafa91900-5e8b-11e8-ba01-2b66550a44f2%2Cinterval%3Aauto%2Cquery%3A(language%3Alucene%2Cquery%3A(query_string%3A(analyze_wildcard%3A!t%2Cdefault_field%3A%27*%27%2Cquery%3A%27*%27)))%2Csort%3A!(%27%40timestamp%27%2Cdesc))">Logs</a></li>

admin/conf/routes

@@ -87,7 +87,6 @@ GET         /commercial/adops/ads-txt
 POST        /commercial/adops/ads-txt                                                               controllers.admin.commercial.AdsDotTextEditController.postAdsDotText()
 GET         /commercial/adops/app-ads-txt                                                           controllers.admin.commercial.AdsDotTextEditController.renderAppAdsDotText()
 POST        /commercial/adops/app-ads-txt                                                           controllers.admin.commercial.AdsDotTextEditController.postAppAdsDotText()
-GET         /commercial/prebid/revenue                                                              controllers.admin.commercial.TeamKPIController.renderPrebidDashboard()
 
 # Config
 

commercial/app/controllers/CommercialControllers.scala

@@ -25,7 +25,6 @@ trait CommercialControllers {
   lazy val piggybackPixelController = wire[PiggybackPixelController]
   lazy val cmpDataController = wire[CmpDataController]
   lazy val adsDotTextFileController = wire[AdsDotTextViewController]
-  lazy val prebidAnalyticsController = wire[PrebidAnalyticsController]
   lazy val passbackController = wire[PassbackController]
   lazy val ampIframeHtmlController = wire[AmpIframeHtmlController]
   lazy val nonRefreshableLineItemsController = wire[nonRefreshableLineItemsController]

commercial/conf/routes

@@ -41,9 +41,6 @@ GET         /commercial/cmp/shortvendorlist.json
 GET         /ads.txt                                                        commercial.controllers.AdsDotTextViewController.renderTextFile()
 GET         /app-ads.txt                                                    commercial.controllers.AdsDotTextViewController.renderAppTextFile()
 
-# Analytics
-POST        /commercial/api/hb                                              commercial.controllers.PrebidAnalyticsController.insert()
-
 # Passbacks
 GET         /commercial/ias-passback/:size                                  commercial.controllers.PassbackController.renderIasPassback(size)
 

common/app/http/RequestLoggingFilter.scala

@@ -29,8 +29,7 @@ class RequestLoggingFilter(implicit val mat: Materializer, executionContext: Exe
                 case _ => ""
               }
           }
-        // don't log uncacheable /commercial/api/hb POST requests due to the volume of them
-        if (rh.method != "POST" || rh.path != "/commercial/api/hb") {
+        if (rh.method != "POST") {
           requestLogger.withResponse(response).info(s"${rh.method} ${rh.uri}$additionalInfo")
         }
       case Failure(error) =>

dev-build/conf/routes

@@ -274,8 +274,6 @@ GET            /commercial/non-refreshable-line-items.json
 
 GET            /ads.txt                                                                                                          commercial.controllers.AdsDotTextViewController.renderTextFile()
 GET            /app-ads.txt                                                                                                          commercial.controllers.AdsDotTextViewController.renderAppTextFile()
-GET            /commercial/prebid/revenue                                                                                        controllers.admin.commercial.TeamKPIController.renderPrebidDashboard()
-POST           /commercial/api/hb                                                                                                commercial.controllers.PrebidAnalyticsController.insert()
 GET            /commercial/ias-passback/:size                                                                                    commercial.controllers.PassbackController.renderIasPassback(size)
 
 # Commercial Admin