Log-shipping fix: adopt crosswordv2 log settings #31
Conversation
|
do we know if this ensures log output is JSON? (so it gets parsed in a structured way by ELK) similarly does it support stack traces (currently they come out as separate lines, which makes debugging v. painful) |
If I'm honest I don't understand all the wizardry which @andrew-nowak put into this for crosswords, but in my experience it's worked really nicely there. An example record from crosswordv2 with separate |
| <pattern>%d{yyyy-MM-dd HH:mm:ss} %highlight(%-5level) %cyan(%logger{36}) %magenta(%X{pekkoSource}) %msg%n</pattern> | ||
| </encoder> | ||
| <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> | ||
| <if condition='property("STAGE").contains("DEV")'> |
There was a problem hiding this comment.
add the .sbtopts file to make this work https://github.com/guardian/crosswordv2/blob/main/.sbtopts (this condition turns off json encoding for running locally, which is much more human readable)
| possibly can be replaced with a JsonEncoder when we can upgrade to | ||
| logback 1.3 https://logback.qos.ch/manual/encoders.html#JsonEncoder | ||
| --> | ||
| <encoder class="net.logstash.logback.encoder.LogstashEncoder" /> |
There was a problem hiding this comment.
this encoder outputs JSON, and does handle newline fields
bryophyta
force-pushed
the
pf/logback-config
branch
from
93a41c8
to
6183d9c
Compare
What does this change?
Copies the logback config that we're using in crosswordv2
It includes a number of changes to
build.sbtas well. It might be that not all of these changes are necessary but I don't understand the jackson eviction stuff well enough to know what's needed and what's not.Initially created because we thought that the broken log shipping was due to our config, though have since realised that there was an upstream issue with logging. Nevertheless, could be a QoL improvement to have nicer logs?
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility