Skip to content

Commit

Permalink
expose less global variables
Browse files Browse the repository at this point in the history
some dependencies are exposed as global variables, also this is not
needed. Those should be exposed via the current context, instead.
  • Loading branch information
johnyb committed Sep 17, 2015
1 parent f49287c commit a920a49
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@

"globals": {
"define": true,
"mimefuncs" : true,
"mimetypes" : true,
"punycode" : true,
"addressparser" : true,
"console": true,
"describe": true,
"it": true,
Expand All @@ -37,4 +33,4 @@
"before": true,
"self": true
}
}
}
4 changes: 2 additions & 2 deletions src/mailbuild.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
} else if (typeof exports === 'object') {
module.exports = factory(require('mimefuncs'), require('mimetypes'), require('punycode'), require('wo-addressparser'));
} else {
root.mailbuild = factory(mimefuncs, mimetypes, punycode, addressparser);
root.mailbuild = factory(root.mimefuncs, root.mimetypes, root.punycode, root.addressparser);
}
}(this, function(mimefuncs, mimetypes, punycode, addressparser) {
'use strict';
Expand Down Expand Up @@ -727,4 +727,4 @@
};

return MimeNode;
}));
}));

0 comments on commit a920a49

Please sign in to comment.