Vamos24 replication #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge VariantSync/DiffDetective into guethilu/DiffDetective
…ncy + remove deprecated assertSemanticConsistency
Behavioural changes: - `EditClassValidationTask` doesn't add export options to the metadata anymore because it doesn't actually export anything. - Bug fix: The tree preprocessing in `MiningTask` was run twice: First for the line graph export and second directly by the `call` method.
For example `#if defined()` was accepted.
In general, `HashMap`s are not deterministic because the default implementation of the hash function might not be deterministic (as in, for example, openjdk 18.0.2). This matters in this case because it's incorrect to replace '>' before '>='.
According to C11, constant expressions (used in macro conditions) can contain all operators available in normal code except assignment, increment, decrement, function-call, or comma operators. (§ 6.6 paragraph 3)
An example where this now works is `#ifdef ifndef`.
Previously, the macro `#if defined A` was not parsed correctly because first the space was removed and afterwards it was tried to replace the `defined` operator.
Note: This changes the abstracted names of macro calls in an backwards incompatible way.
Merge pull request #3 from VariantSync/main
Merge Dockerization into thesis branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.