Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NERACOOS buoy functions #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dzaugis
Copy link
Contributor

@dzaugis dzaugis commented Dec 11, 2020

The buoy functions were made for the lobster forecast but I think they can be used more broadly. Contains four functions. DownloadBuoyCTD, loadNERACOOSnetcdf, makeDailyMean, surfbotcorr. Still need to create a vignette

The buoy functions were made for the lobster forecast but I think they can be used more broadly. Contains four functions. DownloadBuoyCTD, loadNERACOOSnetcdf, makeDailyMean, surfbotcorr. Still need to create a vignette
@@ -0,0 +1,110 @@
DownloadBuoyCTD <- function(buoy, destfolder){
Copy link
Collaborator

@adamkemberling adamkemberling Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roxygen comments will be needed to connect the functions to the "NAMESPACE" documentation. Not sure if the package will "build" without those connections.

Another thing that will flag as a warning or a note is whether or not you specify where a function comes from or not, ex. raster::extract(). Doing that is tedious but helps seperate meaningful warnings from the more benign.

@adamkemberling
Copy link
Collaborator

The buoy data came up last week in a discussion with Dave and Andy Thomas about SST for the NOAA Gulf of Maine quarterly report. Might be worthwhile when we have a breather to circle back on these functions, and possibly get them updating on a schedule as well. I haven't gotten there with SST, so it might be beneficial to go over that together.

@abkfenris
Copy link
Member

@gulfofmaine/ocean-data-products 👋

@adamkemberling
Copy link
Collaborator

Just want to follow up on this since @dzaugis has moved on to advance his career. As-is these functions are just missing documentation for the package to identify the names/arguments. One path forward could be for somebody to tackle that, an alternative could be to adapt the code to use {rerddap}.

Both are viable paths for accessing buoy data, but if we lean more on ERDDAP as a data publishing platform then we could apply a similar access workflow as things get added. Thinking already about buoys, CPR data, CMIP ensemble data etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants