-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support theming and translations via config files #260
Conversation
1fc7818
to
1000066
Compare
messages.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become the new module so users can install it for usage in their .gulp.js
files.
@sttk this is ready for review. Please take a look! I've updated the top comment to describe the feature and updated tests, etc. Thank you for all of the amazing work that I used for the basis of these changes 🙇 ❤️ When we finalize this, I will put together the |
@phated I have replied to your comments. Have a look them. |
@sttk please review again now that I've addressed all your comments. |
@sttk I've address the comments and added documentation. Can you provide a final review so I can make the |
@phated I have added this comment, so please take a look. Otherwise, I think everything is good. |
@sttk Thank you for the thorough review! I am going to create the |
This implements theming and translation support via the
.gulp.js
config files. If a user supplies amessage
function in their config file, we will call it with various message symbols and extra data. The user can return the message they want to print, returnfalse
explicitly to silence the message, or do nothing to fallback to the gulp-cli default message.Since anything logged via
gulplog
will pass through this mechanism, users can also intercept string messages from plugins and return something different.Users can also override the timestamp we print by providing a
timestamp
function in their config file.Closes #63
Closes #177
Closes #206
Closes #161 (replaces it)