-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Refactor Rollup recipe #2503
base: master
Are you sure you want to change the base?
Conversation
b121e5d
to
39097d2
Compare
Nothing extra is needed to use Rollup with gulp, so this refactors the recipe to use Rollup's JavaScript API directly.
39097d2
to
f465588
Compare
Alternatively, I could add this next to the |
I believe this recipe should describe both:
I think we can include both in this recipe. |
@silvenon I also think this recipe should just be called "Bundling JavaScript", since it will be the recommended way to include bundling inside your gulpfiles. |
I started working on this again. My plan is to rename this to "Using Module Bundlers" instead because I also want to add webpack and esbuild, both of which support other bundling other assets, not just JavaScript. I'll finish Rollup in the following days and as separate PRs I'll add other bundlers as well. |
@silvenon I think that is a great plan! Thank you for updating us. |
@silvenon are you still planning to complete the above changes? |
No, sorry, I lost my drive for some reason. 😔 I'll open a new PR once I get it back. |
Thanks for letting me know! I'd like to re-open and pick this up myself. And thank you for the work you put in here already ❤️ |
Nothing extra is needed to use Rollup with gulp, so this refactors the
recipe to use Rollup's JavaScript API directly.