PyPI Publish GH Action #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial nonworking draft of structure
add link to cibuildwheel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #400 +/- ##
==========================================
+ Coverage 95.84% 95.91% +0.06%
==========================================
Files 24 24
Lines 7275 7312 +37
==========================================
+ Hits 6973 7013 +40
+ Misses 302 299 -3 ☔ View full report in Codecov by Sentry. |
gumyr
reviewed
Nov 30, 2023
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Build wheels | ||
| uses: pypa/[email protected] |
There was a problem hiding this comment.
Does cibuildwheel need to be installed?
There was a problem hiding this comment.
I could be wrong, but not to my knowledge. uses: pypa/[email protected] should install cibuildwheel within the GH action runner.
| runs-on: ubuntu-latest | ||
| environment: | ||
| name: pypi | ||
| url: https://pypi.org/p/build123d |
There was a problem hiding this comment.
Is https://pypi.org/p/build123d short for https://pypi.org/project/build123d? Do either work?
There was a problem hiding this comment.
Yes, that is a shortcut and either will work (from PyPI docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for testing, it is setup to publish to the PyPI testing target (not any real PyPI target). There may need to be some changes made to
pyproject.tomlbut I have not done that yet. Further info aboutpyproject.tomlis here:https://cibuildwheel.readthedocs.io/en/stable/options/