Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: remove OCP-stubs as dependency #411

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

jdegenstein
Copy link
Collaborator

preparing for PyPI release that does not allow depending on GH repos

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f622815) 95.91% compared to head (afd1127) 95.90%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #411      +/-   ##
==========================================
- Coverage   95.91%   95.90%   -0.01%     
==========================================
  Files          24       24              
  Lines        7313     7321       +8     
==========================================
+ Hits         7014     7021       +7     
- Misses        299      300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

won't work with PyPI with OCP-stubs from github
@jdegenstein jdegenstein changed the title pyproject.toml: move OCP-stubs to optional dependencies pyproject.toml: remove OCP-stubs as dependency Dec 2, 2023
@jdegenstein
Copy link
Collaborator Author

Probably best to wait on this until the other GH deps are on PyPI, but updated to remove OCP-stubs as a dep altogether.

@gumyr gumyr merged commit 5aa3aa8 into gumyr:dev Dec 5, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants