Fix JernArc not always co-planar with input plane #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #635 in which I determined that the localization of the tangent vector was resulting in an incorrect tangent direction. Ultimately it was discovered that this problem went to a fairly low level within build123d and is related to how affine transformations in OCCT do not affect
gp_Vec, gp_Pnt, and gp_Dir
in the same ways. In particular a tangent direction is analogous to agp_Dir
that should not be affected by translation or scaling, and only by the rotations. The existing Vector.transform method was extended to include an affine transformation option forgp_Dir
. JernArc was reworked to depend on this newly created functionality in Vector.transform.I also added additional tests to cover the newly added features and more tests for JernArc itself.
I am looking for input on whether this change makes architectural sense and is not overly simplistic and so would lead to problems in the future.