Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New section "Iterating Over Compounds" to Assembly documentation. #713

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

slobberingant
Copy link
Contributor

Iterating over compounds like this has been a solution to a few of my previous problems and I haven't seen it in the documentation. Hope it helps.

Copy link
Owner

@gumyr gumyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change if you don't mind. The sum doesn't need the list comprehension, if its implemented as sum(part.volume for part in assembly3.solids()) it is called a generator expression and is the recommended way to do sums like this.

docs/assemblies.rst Outdated Show resolved Hide resolved
@slobberingant
Copy link
Contributor Author

Feedback has been incorporated. Thank you.

@gumyr gumyr merged commit 55f6e8f into gumyr:dev Sep 26, 2024
10 of 11 checks passed
@gumyr
Copy link
Owner

gumyr commented Sep 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants