-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Shell.loft #767
Added Shell.loft #767
Conversation
When running black latest it changes existing formatting is the version to use pinned somewhere? Or do I need to do something special to get the correct formatting? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #767 +/- ##
==========================================
+ Coverage 96.05% 96.08% +0.03%
==========================================
Files 25 25
Lines 8387 8463 +76
==========================================
+ Hits 8056 8132 +76
Misses 331 331 ☔ View full report in Codecov by Sentry. |
Ok so I've found what was the issue, my black was setup to line per char = 100, the default is 88. |
@Jojain the defaults to use black ARE setup in pyproject.toml, including the 88 char setting you mentioned We haven't settled on a stable black version to use, so for now the newest is fine. |
You are right, I think I got confused, because I had a pyproject toml without it. But I think it was before I update everything. |
Thank you - loft is better than it ever was! |
I also wanted to add the shell loft into the shell operations but that is rather involved to make it work in
BuildPart
I think for it to work we would need to be able to have a list of available
Wire
in theBuildPart
context, which currently arent stored.It wouldn't be has difficult for the algebra api part.