Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shell.loft #767

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Added Shell.loft #767

merged 3 commits into from
Nov 8, 2024

Conversation

Jojain
Copy link
Contributor

@Jojain Jojain commented Nov 7, 2024

I also wanted to add the shell loft into the shell operations but that is rather involved to make it work in BuildPart
I think for it to work we would need to be able to have a list of available Wire in the BuildPart context, which currently arent stored.

It wouldn't be has difficult for the algebra api part.

@Jojain
Copy link
Contributor Author

Jojain commented Nov 7, 2024

When running black latest it changes existing formatting is the version to use pinned somewhere? Or do I need to do something special to get the correct formatting?

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (82af584) to head (8fd5a67).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
src/build123d/topology.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #767      +/-   ##
==========================================
+ Coverage   96.05%   96.08%   +0.03%     
==========================================
  Files          25       25              
  Lines        8387     8463      +76     
==========================================
+ Hits         8056     8132      +76     
  Misses        331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jojain
Copy link
Contributor Author

Jojain commented Nov 8, 2024

Ok so I've found what was the issue, my black was setup to line per char = 100, the default is 88.
I would still like that you provide somewhere a config to run black with so I don't have to modify my settings to contribute.

@jdegenstein
Copy link
Collaborator

@Jojain the defaults to use black ARE setup in pyproject.toml, including the 88 char setting you mentioned

We haven't settled on a stable black version to use, so for now the newest is fine.

@Jojain
Copy link
Contributor Author

Jojain commented Nov 8, 2024

@Jojain the defaults to use black ARE setup in pyproject.toml, including the 88 char setting you mentioned

We haven't settled on a stable black version to use, so for now the newest is fine.

You are right, I think I got confused, because I had a pyproject toml without it. But I think it was before I update everything.
Anyway idk, sorry for the request then !

@gumyr gumyr merged commit 7ae5026 into gumyr:dev Nov 8, 2024
13 checks passed
@gumyr
Copy link
Owner

gumyr commented Nov 8, 2024

Thank you - loft is better than it ever was!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants