use pathlib to manage path names in import/export functions #786
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roipoussiere
force-pushed
the
pathlib
branch
from
a89f6c3
to
9f503d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 25 25
Lines 8472 8474 +2
=======================================
+ Hits 8141 8143 +2
Misses 331 331 ☔ View full report in Codecov by Sentry. |
|
I don't think this has ever happened before but two PR covering the same change arrived within 4 hours. PR #787 is more comprehensive so I think it makes sense to continue with that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #774