Codegen Test Macro #114
Draft
Codegen Test Macro #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gussmith23
requested changes
Jul 14, 2021
| @@ -1938,234 +1938,202 @@ mod tests { | |||
| } | |||
| relay_outputs | |||
| } | |||
| macro_rules! codegen_test { | |||
There was a problem hiding this comment.
Suggested change
| macro_rules! codegen_test { | |
| /// <Need documentation here!> | |
| macro_rules! codegen_test { |
There was a problem hiding this comment.
Please add this newline, and add a docstring for your new macro!
src/codegen.rs
Outdated
| macro_rules! codegen_test { | ||
| ($input_vec: expr, $code_expr: expr, $code_tup: expr, $ground_truth : expr, $c_code : expr) => { | ||
| let mut map: HashMap<String, Vec<usize>> = HashMap::default(); | ||
| let shape_vec = $input_vec; |
There was a problem hiding this comment.
Is this really a "shape vec"? Or is a vector of (name, value) pairs? Maybe just call it "environment" or "env"?
|
I'm going to hold off on further comments until after our meeting today. |
vcanumalla
force-pushed
the
codegen-macro
branch
from
cf78b5c
to
0251c27
Compare
vcanumalla
force-pushed
the
codegen-macro
branch
from
1b223e6
to
b059efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve issue #34 at least partially. Currently in stage of rewriting the tests, and adding additional cases for the macro to cover. Still needs a good amount of drone work.