Add missing lal declarations

[spxiwh]

@duncanmmacleod Reported that sbank is failing to build on newest clang releases due to missing declarations. This adds the missing declarations (hopefully). Can you approve (if this passes tests etc.)?

@duncanmmacleod A related request to you: I shouldn't have to be doing this! As with numpy, there should be some way to find lalsuite's .h files, so I can just include them. I also need a way to find lalsuite's so files to link against, which doesn't require the horrible hack that sbank's packaging currently has. Adding these would greatly increase the ability to use Cython with lalsuite (this is better than SWIG because I can interact directly at the C layer).

[duncanmmacleod]

@duncanmmacleod A related request to you: I shouldn't have to be doing this! As with numpy, there should be some way to find lalsuite's .h files, so I can just include them. I also need a way to find lalsuite's so files to link against, which doesn't require the horrible hack that sbank's packaging currently has. Adding these would greatly increase the ability to use Cython with lalsuite (this is better than SWIG because I can interact directly at the C layer).

LAL provides a pkg-config (.pc) file in (almost?) all distributions which can be queried to find the include directory, library directorys, library names, etc, e.g:

$ pkg-config --cflags --libs lal
-pthread -I/home/duncan/opt/mambaforge/envs/py311/include -L/home/duncan/opt/mambaforge/envs/py311/lib -llal

[spxiwh]

Hmm, okay ... It's getting late here now, but I'll try and demonstrate the failure I see when building sbank directly linking to LAL (if it still exists ... It's been some time since I tried this).

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.36%. Comparing base (de73773) to head (627ffd2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   55.36%   55.36%           
=======================================
  Files          10       10           
  Lines        1167     1167           
=======================================
  Hits          646      646           
  Misses        521      521           

Flag	Coverage Δ
Linux	?
macOS	55.36% <ø> (ø)
python3.10	?
python3.11	55.36% <ø> (ø)
python3.8	55.41% <ø> (ø)
python3.9	55.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[spxiwh]

For now, can we merge this though :-)

[spxiwh]

@duncanmmacleod LAL does not provide the pkg-config file in pypi builds. This causes issues when trying to build pypi wheels. We use the pypi lalsuite wheels to build sbank's pypi wheels (which makes the most sense in terms of consistency), but linking against it becomes difficult when we don't know where to find either the libraries, or the header files.

[duncanmmacleod]

Ok, good point, I wasn't sure how the wheels for this project were built.

@lpsinger might have some suggestions on the best way to solve this problem, otherwise I think it's a reasonable feature request to have the LAL Python library provide a get_library_{dir,name} or similar functions.

[duncanmmacleod]

LGTM