Modified Parsoid client to accept JSON tests rather than test / prefix. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should not check the parsoid code into testreduce. Could you submit a patch against parsoid using the instructions at http://www.mediawiki.org/wiki/Gerrit/Getting_started ? |
|
Sure thing. In that case this should probably be closed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23
Did not modify the getTitle part of the code to use the oldID in the test JSON input.
I had to fake the git commits in order to get a list of "valid" git commits. Calling exec on ' git log --max-count=1 --pretty=format:"%H %ci" ' won't produce any valid parsoid commits since the git commits in test reduce are completely different from the actual parsoid commits.