-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front Page averages, revision summaries, histogram of fails/skips #40
base: master
Are you sure you want to change the base?
Conversation
@gwicke Also, I was looking into where to add the check for removing a test if the number of fetch errors reached the max. I was a little confused about how the testQueue is currently working. It seems like we init and fill it when the server starts up, then keep on dequeuing when we give out tests. Do we ever refill the test queue (like when we get a new commit)? Should we? |
@jjchen We should re-fill the test queue when we get a new commit. If we don't do so yet, then that's something we should add. It's probably not that hard. |
Okay, cool. Yeah, that's what I thought - I didn't see where we were doing it, I'll check again and add it if we're not. |
} | ||
cb(null, 0, results.rows.length); | ||
} | ||
}; | ||
|
||
// get tests | ||
var cql = 'select test from tests;'; | ||
var cql = 'select * from tests;'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be safer to explicitly list the fields you are expecting and in which order. If we refactor the schema it's better to get a query failure than getting unexpected data in specific offsets.
#17 : averages of skip/fail/error calculated in getStatistics, saved to revision summary table in updateCommit. Also changed the score function to be 10000*failscount.
#38 : finished failsDistr and skipsDistr. Finished frontend of failedFetches. Still need to figure out where to save the failed fetches info.