fix: avoid confusion if setup-auth is already ran before #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an in the outer scope this plugin doesn't fail
…credentials-explicitly
genisd
changed the title
This reverts commit 746bda0.
… hopefully not interefere with our own auth
genisd
force-pushed
the
fix/set-location-of-credentials-explicitly
branch
from
341f860 to
4fcd35f
Compare
genisd
commented
Apr 17, 2024
| await writeFile("sa.json", sa_json); | ||
| await exec.exec(GCLOUD_BINARY, ['auth', 'activate-service-account', '--key-file=sa.json']); | ||
| await exec.exec(GCLOUD_BINARY, ['container', 'clusters', 'get-credentials', name, '--zone', location, '--project', project]); | ||
| const account = JSON.parse(sa_json).client_email; // get the account passed in. this will prevent issues when multiple accounts have been activated |
genisd
commented
Apr 17, 2024
| location, | ||
| "--project", | ||
| project, | ||
| "--account", |
genisd
commented
Apr 17, 2024
index.js
Outdated
| await deleteFile("sa.json"); | ||
| } | ||
|
|
||
| function unsetGloudariables() { |
genisd
commented
Apr 17, 2024
index.js
Outdated
| @@ -164,6 +193,8 @@ async function run() { | |||
| const context = github.context; | |||
| await status("pending"); | |||
|
|
|||
| unsetGloudariables(); | |||
fhp
approved these changes
Apr 17, 2024
genisd
force-pushed
the
fix/set-location-of-credentials-explicitly
branch
from
8153487 to
6a0643b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.