Skip to content

Commit

Permalink
Typo on readme
Browse files Browse the repository at this point in the history
  • Loading branch information
@gysmo38
gysmo38 committed Nov 12, 2022
1 parent aba34a0 commit 2f439c6
Show file tree
Hide file tree
Showing 7 changed files with 139 additions and 156 deletions.
6 changes: 3 additions & 3 deletions src/mitsubishi2mqtt/config.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand All @@ -16,7 +16,7 @@

//#define MY_LANGUAGE fr-FR // define your language

const PROGMEM char* m2mqtt_version = "2022.01";
const PROGMEM char* m2mqtt_version = "2022.11";

//Define global variables for files
#ifdef ESP32
Expand Down Expand Up @@ -95,7 +95,7 @@ uint8_t max_temp = 31; // Maximum temperature, in your select
String temp_step = "1"; // Temperature setting step, check value from heatpump remote control

// sketch settings
const PROGMEM uint32_t SEND_ROOM_TEMP_INTERVAL_MS = 45000; // 45 seconds (anything less may cause bouncing)
const PROGMEM uint32_t SEND_ROOM_TEMP_INTERVAL_MS = 30000; // 45 seconds (anything less may cause bouncing)
const PROGMEM uint32_t MQTT_RETRY_INTERVAL_MS = 1000; // 1 second
const PROGMEM uint32_t HP_RETRY_INTERVAL_MS = 1000; // 1 second
const PROGMEM uint32_t HP_MAX_RETRIES = 10; // Double the interval between retries up to this many times, then keep retrying forever at that maximum interval.
Expand Down
2 changes: 1 addition & 1 deletion src/mitsubishi2mqtt/html_common.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand Down
2 changes: 1 addition & 1 deletion src/mitsubishi2mqtt/html_init.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand Down
2 changes: 1 addition & 1 deletion src/mitsubishi2mqtt/html_menu.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand Down
2 changes: 1 addition & 1 deletion src/mitsubishi2mqtt/html_pages.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand Down
2 changes: 1 addition & 1 deletion src/mitsubishi2mqtt/javascript_common.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
mitsubishi2mqtt - Mitsubishi Heat Pump to MQTT control for Home Assistant.
Copyright (c) 2019 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
Copyright (c) 2022 gysmo38, dzungpv, shampeon, endeavour, jascdk, chrdavis, alekslyse. All right reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
Expand Down
Loading

1 comment on commit 2f439c6

@hhinma
Copy link

@hhinma hhinma commented on 2f439c6 Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gysmo38 I'm probably completely misunderstanding something, but the changes at 1535/1517 removing the else clause from the curr_temp_tpl_str construction appear to result in the template evaluating to null for low temperatures. That particular clause has been present as far back as I can see in the history. Was this intentional?

Please sign in to comment.