Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some steps to verify the appdata metadata #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abestanis
Copy link
Collaborator

@Abestanis Abestanis commented Oct 29, 2023

This depends on #580, because with the current screenshot the verification fails with the following error:

src/res/com.ulduzsoft.Birdtray.appdata.xml: FAILED:
• attribute-invalid     : <screenshot> width too large [https://raw.githubusercontent.com/gyunaev/birdtray/master/screenshots/birdtray-settings.png] maximum is 1600px
• attribute-invalid     : <screenshot> height too large [https://raw.githubusercontent.com/gyunaev/birdtray/master/screenshots/birdtray-settings.png] maximum is 900px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/gyunaev/birdtray/master/screenshots/birdtray-settings.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/gyunaev/birdtray/master/screenshots/birdtray-settings.png]
Validation of files failed

The errors disappear with the new screenshot, see the CI on commit 540baee.

@Abestanis Abestanis marked this pull request as draft October 30, 2023 02:07
@Abestanis Abestanis force-pushed the test/ensure_flatpack_metadata branch from 540baee to 21cd374 Compare November 4, 2023 21:42
@Abestanis Abestanis requested a review from gyunaev November 4, 2023 21:45
@Abestanis Abestanis self-assigned this Nov 4, 2023
@Abestanis
Copy link
Collaborator Author

This is ready to be reviewed, but I'll leave it marked as a draft until #580 is merged.

@Abestanis Abestanis force-pushed the test/ensure_flatpack_metadata branch from 21cd374 to b5a1606 Compare April 6, 2024 12:10
@Abestanis Abestanis marked this pull request as ready for review April 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant