Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal endpoint for user account creation #17

Closed
h1alexbel opened this issue Jun 2, 2024 · 9 comments · Fixed by #61
Closed

internal endpoint for user account creation #17

h1alexbel opened this issue Jun 2, 2024 · 9 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@h1alexbel
Copy link
Owner

h1alexbel commented Jun 2, 2024

On the public GitHub API there is no ability to create GitHub account, however we should provide this ability in our API. I suggest to create an endpoint POST /users with body like this: username + password that will create a user account.

@h1alexbel h1alexbel added the enhancement New feature or request label Jun 2, 2024
@h1alexbel
Copy link
Owner Author

@l3r8yJ WDYT?

@h1alexbel h1alexbel added this to the 0.0.1 milestone Jun 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

@h1alexbel thanks for the report, here is a feedback:

Problems

  1. Lack of impact or urgency
  2. Lack of suggested solution

I would recommend providing an example of the expected request payload for the POST /users endpoint.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@h1alexbel
Copy link
Owner Author

I'm in

@h1alexbel h1alexbel self-assigned this Jul 9, 2024
h1alexbel added a commit that referenced this issue Jul 10, 2024
h1alexbel added a commit that referenced this issue Jul 10, 2024
h1alexbel added a commit that referenced this issue Jul 10, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
feat(#17): register_user, Storage redesigned to struct
@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2024

@h1alexbel 3 puzzles #73, #74, #75 are still not solved.

@0pdd
Copy link
Collaborator

0pdd commented Jul 21, 2024

@h1alexbel 2 puzzles #73, #75 are still not solved; solved: #74.

@0pdd
Copy link
Collaborator

0pdd commented Jul 24, 2024

@h1alexbel 3 puzzles #73, #98, #99 are still not solved; solved: #74, #75.

@0pdd
Copy link
Collaborator

0pdd commented Jul 24, 2024

@h1alexbel 4 puzzles #101, #73, #98, #99 are still not solved; solved: #74, #75.

@0pdd
Copy link
Collaborator

0pdd commented Sep 2, 2024

@h1alexbel the puzzle #101 is still not solved; solved: #73, #74, #75, #98, #99.

@0pdd
Copy link
Collaborator

0pdd commented Sep 11, 2024

@h1alexbel all 6 puzzles are solved here: #101, #73, #74, #75, #98, #99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants