Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user.rs:44-46: Configure clippy to reject code with... #74

Closed
0pdd opened this issue Jul 11, 2024 · 6 comments · Fixed by #90
Closed

user.rs:44-46: Configure clippy to reject code with... #74

0pdd opened this issue Jul 11, 2024 · 6 comments · Fixed by #90
Assignees
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2024

The puzzle 17-e45e524d from #17 has to be resolved:

// @todo #17:30min Configure clippy to reject code with #unwrap().
// We should prohibit to use #unwrap() function in our code. Let's configure
// clippy tool in the respective manner and get rid of all #unwrap() calls.

The puzzle was created by @h1alexbel on 11-Jul-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 0pdd added bug Something isn't working pdd labels Jul 11, 2024
0pdd referenced this issue Jul 11, 2024
feat(#17): register_user, Storage redesigned to struct
Copy link

@0pdd thanks for the report, here is a feedback:

  • Avoid using #unwrap() method as it may cause a panic in the program. Instead, use proper error handling techniques such as match or the ? operator.
  • Consider adding a comment to explain the purpose of the #[cfg(test)] attribute.
  • The todo message suggests configuring clippy to reject code with #unwrap(). However, there is no indication of how to do this. It would be helpful to provide a link to the clippy documentation or an example of how to configure clippy to reject #unwrap() calls.

The message could be improved by providing more specific guidance on how to configure clippy and what alternatives to use instead of #unwrap(). Additionally, the message could benefit from a clearer explanation of why #unwrap() should be avoided.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2024

@0pdd thanks for the report, here is a feedback: * Avoid using #unwrap() method as it may cause a ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

@h1alexbel
Copy link
Owner

@l3r8yJ can you help here?

@l3r8yJ
Copy link
Collaborator

l3r8yJ commented Jul 11, 2024

@h1alexbel sure

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 24, 2024

@0pdd the puzzle #101 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Sep 11, 2024

@0pdd the only puzzle #101 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants