Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args.rs:24-27: Handle port argument We should process the... #43

Closed
0pdd opened this issue Jun 23, 2024 · 3 comments · Fixed by #60
Closed

args.rs:24-27: Handle port argument We should process the... #43

0pdd opened this issue Jun 23, 2024 · 3 comments · Fixed by #60
Assignees
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 23, 2024

The puzzle 13-97a91bb1 from #13 has to be resolved:

fakehub/cli/src/args.rs

Lines 24 to 27 in f8bde4e

// @todo #13:15min Handle port argument
// We should process the port argument and
// pass it to the server on `start` command.
// Start command should be added also with clap

The puzzle was created by @h1alexbel on 23-Jun-24.

Estimate: 15 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 0pdd added bug Something isn't working pdd labels Jun 23, 2024
0pdd referenced this issue Jun 23, 2024
feat(multi-module): splitted to modules
@0pdd 0pdd mentioned this issue Jun 23, 2024
Copy link

@0pdd thanks for the report, here is a feedback:

  • The todo message is not clear about what specific issue needs to be addressed with the port argument processing. It would be better if the todo message mentioned what exactly needs to be implemented, like "Handle port argument: Implement validation for the port number."
  • The todo message does not specify which part of the code should add the start command with clap. It would be helpful if it mentioned where this change should be made, like "Add start command with clap in the main.rs file."
  • The todo message could be more concise. It mentions two separate actions (handling port argument and adding start command with clap), which could be combined into one clearer message: "Implement port argument handling and add start command with clap."

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@h1alexbel h1alexbel self-assigned this Jun 23, 2024
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 23, 2024

@0pdd thanks for the report, here is a feedback: * The todo message is not clear about what specific...

I see you're talking to me, but I can't reply since I'm not a chat bot.

h1alexbel added a commit that referenced this issue Jul 11, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
Co-authored-by: Ivan Ivanchuk <[email protected]>
h1alexbel added a commit that referenced this issue Jul 11, 2024
Co-authored-by: Ivan Ivanchuk <[email protected]>
h1alexbel added a commit that referenced this issue Jul 11, 2024
h1alexbel added a commit that referenced this issue Jul 11, 2024
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2024

@0pdd the puzzle #76 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants