feat(#43): fakehub start, --port #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
===========================================
- Coverage 58.82% 20.40% -38.42%
===========================================
Files 5 5
Lines 17 49 +32
===========================================
Hits 10 10
- Misses 7 39 +32 ☔ View full report in Codecov by Sentry. |
l3r8yJ
requested changes
Jul 10, 2024
cli/tests/integration_test.rs
Outdated
|
|
||
| #[test] | ||
| fn outputs_start_opts() -> Result<()> { | ||
| env!("CARGO_BIN_EXE_cli"); |
There was a problem hiding this comment.
@h1alexbel btw I'm not sure that this is an required, can you try to remove it?
There was a problem hiding this comment.
@l3r8yJ removed, test passed.
|
@l3r8yJ take a look, again please |
l3r8yJ
requested changes
Jul 11, 2024
cli/tests/integration_test.rs
Outdated
| #[test] | ||
| #[ignore] | ||
| fn starts_server() -> Result<()> { | ||
| env!("CARGO_BIN_EXE_cli"); |
Co-authored-by: Ivan Ivanchuk <[email protected]>
Co-authored-by: Ivan Ivanchuk <[email protected]>
|
@l3r8yJ updated |
l3r8yJ
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@l3r8yJ take a look, please
closes #43
PR-Codex overview
Focus: Refactoring CLI to support starting a server with logging.
Detailed summary
log::infofor logging.Serverstruct.Argsstruct withCommandenum.Startsubcommand for starting the server.