Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#130): request format, improvements in README #131

Merged
merged 3 commits into from
Sep 2, 2024
Merged

feat(#130): request format, improvements in README #131

merged 3 commits into from
Sep 2, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Sep 2, 2024

closes #130


PR-Codex overview

The focus of this PR is to update the fakehub CLI tool to mimic the GitHub REST API accurately.

Detailed summary

  • Renamed GitHub API to GitHub REST API for clarity.
  • Improved documentation for fakehub usage and request format.
  • Added caution against using personal tokens.
  • Enhanced contribution guidelines.
  • Updated references to GitHub API to GitHub REST API.
  • Added example request for Get a repository endpoint.
  • Clarified supported API operations in fakehub.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (8d30393) to head (15ae1d7).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files           7        7           
  Lines          95       95           
=======================================
  Hits           52       52           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 2, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 60d120a into master Sep 2, 2024
14 checks passed
@rultor
Copy link
Collaborator

rultor commented Sep 2, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 52min)

@0crat
Copy link

0crat commented Sep 10, 2024

@h1alexbel Hey there! Thanks for your contribution! 👍 You've earned +4 points, but there's room for improvement. We missed out on some points due to no code review and only 3 comments. Remember, reviews and comments are crucial - they help us all learn and grow! Next time, aim for at least 6 comments and don't forget to get your code reviewed. Keep pushing those hits-of-code, but remember quality matters too. Your current balance is -16. Looking forward to your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standardize docs
3 participants