-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#174): arc github lock #176
Conversation
@h1alexbel can we wait this pr before merging this one? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 83.15% 82.13% -1.03%
==========================================
Files 16 16
Lines 285 291 +6
==========================================
+ Hits 237 239 +2
- Misses 48 52 +4 ☔ View full report in Codecov by Sentry. |
@l3r8yJ I think yes, if it would be fast to merge |
@l3r8yJ take a look, please |
@l3r8yJ take a look, please |
1 similar comment
@l3r8yJ take a look, please |
@h1alexbel Hey there, awesome work on your contribution! 👍 You've earned +4 points, which breaks down like this: +4 base points, +6 for your 139 hits-of-code (nice job!), but -16 because there wasn't a code review (oops!). We bumped it up by +9 to keep you motivated. Your total balance is now +63. Remember, code reviews are super important - they can boost your points and improve code quality. Keep the contributions coming and aim for that sweet spot of 200-800 hits-of-code for max points! Keep up the great work! |
In this pull I've fixed bug with broken user registration via
Arc<Mutex<GitHub>>
, introduced new tests to catch this problem in the future.closes #174
History:
PR-Codex overview
This PR focuses on enhancing thread safety in the
FakeHub
structure by usingArc<Mutex<GitHub>>
, ensuring concurrent access is managed properly. Additionally, it refactors various functions and updates user handling to improve reliability and maintainability.Detailed summary
github
inFakeHub
toArc<Mutex<GitHub>>
for thread safety.main()
method to returnArc<Mutex<GitHub>>
.Coordinates
struct to hold a reference toFakeHub
.