Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#168): optimized rultor build #180

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat(#168): optimized rultor build #180

merged 2 commits into from
Oct 1, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 1, 2024

In this pull, I've optimized rultor build for both: release and merge, removed redundant command executions in release section.

ref #168


PR-Codex overview

This PR focuses on updating the build process in the GitHub Actions workflow and the justfile. It modifies the installation steps and code generation commands, streamlining the process and removing unnecessary npm commands.

Detailed summary

  • Updated run commands in .github/workflows/codecov.yml to include just install before just gen.
  • Removed npm --version checks and installation of @openapitools/openapi-generator-cli from the gen and rultor sections.
  • Replaced npm install with just gen in the rultor section.
  • Added export RULTOR=true in the merge section.
  • Simplified the gen command to use ${RULTOR:+sudo} for conditional sudo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (af11195) to head (e81b1dc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          16       16           
  Lines         285      285           
=======================================
  Hits          237      237           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel h1alexbel merged commit 287181f into master Oct 1, 2024
14 checks passed
@h1alexbel h1alexbel deleted the 168 branch October 1, 2024 12:58
@0crat
Copy link

0crat commented Oct 1, 2024

@h1alexbel Thanks for your contribution! Your reward is +4 points, calculated as follows: +4 base, -16 for no code review, -4 for insufficient comments (only 1), and +20 to meet the minimum. While this isn't ideal, remember that quality and speed are both crucial. For future contributions, ensure you get a code review and encourage more comments to maximize your points. Your current balance stands at +51. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants