Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#157): test tagging via tagrs #183

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat(#157): test tagging via tagrs #183

merged 4 commits into from
Oct 2, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 2, 2024

closes #157


PR-Codex overview

This PR introduces a new dependency, updates CI configurations, and modifies the justfile for improved build and test processes. It also adds new test cases and applies a tagging system for better organization.

Detailed summary

  • Added tagrs dependency in cli/Cargo.toml.
  • Updated GitHub Actions workflow to run just full "deep,fast".
  • Introduced two new tests (outputs_help, outputs_start_opts) tagged as "deep" in cli/tests/integration_test.rs.
  • Modified full target in justfile to accept tests parameter.
  • Updated build target to take tests parameter.
  • Changed test target to use a which parameter.
  • Updated Rultor merge script to run tests with the tag "deep,fast".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (c23e170) to head (1feccaa).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          16       16           
  Lines         285      285           
=======================================
  Hits          237      237           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 2, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1feccaa into master Oct 2, 2024
14 checks passed
@h1alexbel h1alexbel deleted the 54 branch October 2, 2024 16:57
@rultor
Copy link
Collaborator

rultor commented Oct 2, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 55min)

@0crat
Copy link

0crat commented Oct 3, 2024

@h1alexbel Thanks for your contribution! You've earned +4 points: +4 base, -16 for no code review, -4 for only 3 comments (our policy requires at least 6), and +20 to meet the minimum 4-point reward. Remember, code reviews and more comments can significantly boost your points next time. Your running balance is now +59. Keep the contributions coming and aim for that quality-speed balance! 💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration_test.rs:66-72: Find a way to run slow tests...
3 participants