Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#196): full-cycle shell-tests #200

Merged
merged 9 commits into from
Oct 9, 2024
Merged

feat(#196): full-cycle shell-tests #200

merged 9 commits into from
Oct 9, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 9, 2024

closes #196


PR-Codex overview

This PR adds a new test script and updates the GitHub Actions workflow to automate shell tests for a Rust application. It includes a license notice and checks server startup and shutdown.

Detailed summary

  • Added a license notice to tests/full-cycle.sh.
  • Created a script in tests/full-cycle.sh to test server startup and shutdown.
  • Added a new GitHub Actions workflow in .github/workflows/shell-tests.yml to run shell tests on push and pull requests to master.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (c513ad7) to head (144d02a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files          20       20           
  Lines         328      328           
=======================================
  Hits          245      245           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit db27fbe into master Oct 9, 2024
13 checks passed
@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 12min).

@0crat
Copy link

0crat commented Oct 10, 2024

@h1alexbel Thanks for your contribution! We've reviewed your submission and calculated your points according to our policy. You've earned +4 points: +4 as a base, -16 for lack of code review, -4 for insufficient comments (only 3), and +20 to ensure a minimum reward. While we appreciate your effort, please note that code reviews and comments are crucial for maintaining code quality. Your current balance stands at +39. We encourage you to continue contributing and to engage more in the review process for future submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test case for fakehub start -> fakehub stop
3 participants