-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi-module): splitted to modules #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ take a look, please. BTW, maybe let's name module like that: fakehub-cli
, fakehub-server
, wdyt?
server/Cargo.toml
Outdated
@@ -0,0 +1,24 @@ | |||
[package] | |||
name = "fakehub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be server
in order to be built by cargo
@h1alexbel does it make any sense to have |
@l3r8yJ let's drop the prefix then |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
===========================================
+ Coverage 22.58% 53.33% +30.75%
===========================================
Files 3 4 +1
Lines 31 15 -16
===========================================
+ Hits 7 8 +1
+ Misses 24 7 -17 ☔ View full report in Codecov by Sentry. |
@h1alexbel take a look, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ take a look, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ let's stay with default |
@h1alexbel in general PR is ready and you can review it, but I have small problem with build. While i'm trying to find WA, i've posted a question on SO, hope someone will answer sooner than I'll fix it by myself |
@h1alexbel take a look, please |
ref: #13
ref: #26
@h1alexbel take a look, please
PR-Codex overview
This PR updates the Cargo workflows, adds Clap for argument parsing, and refactors code structure.
Detailed summary