Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#44): features, opt clap #46

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat(#44): features, opt clap #46

merged 1 commit into from
Jun 24, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Jun 24, 2024

@l3r8yJ take a look, please.

closes #44


PR-Codex overview

The focus of this PR is to add optional dependencies for CLI features and define feature flags for different CLI components.

Detailed summary

  • Added optional dependencies for clap_complete, clap_mangen, and clap_complete_nushell
  • Defined feature flags for cli with specific dependencies for different CLI components

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel h1alexbel requested a review from l3r8yJ June 24, 2024 07:51
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.33%. Comparing base (f8bde4e) to head (fce2ded).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files           4        4           
  Lines          15       15           
=======================================
  Hits            8        8           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@l3r8yJ l3r8yJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel looks good to me!

Copy link

@l3r8yJ

excellent review

Analyzed with Phind/Phind-CodeLlama-34B-v2

@h1alexbel
Copy link
Owner Author

h1alexbel commented Jun 24, 2024

@l3r8yJ let's try this rultor image: image: yegor256/rultor-image:1.23.1

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 24, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 671c79a into master Jun 24, 2024
17 checks passed
@rultor
Copy link
Collaborator

rultor commented Jun 24, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 9min)

@h1alexbel h1alexbel deleted the 44 branch June 24, 2024 09:29
@h1alexbel
Copy link
Owner Author

nice, this image works!
@l3r8yJ FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

features block in Cargo.toml
3 participants