-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#44): features, opt clap #46
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 53.33% 53.33%
=======================================
Files 4 4
Lines 15 15
=======================================
Hits 8 8
Misses 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel looks good to me!
excellent review Analyzed with |
@l3r8yJ let's try this rultor image: |
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 9min) |
nice, this image works! |
@l3r8yJ take a look, please.
closes #44
PR-Codex overview
The focus of this PR is to add optional dependencies for CLI features and define feature flags for different CLI components.
Detailed summary
clap_complete
,clap_mangen
, andclap_complete_nushell
cli
with specific dependencies for different CLI components